-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport mu-wpcom-plugin 2.1.27, jetpack 13.5-a.3 Changes #37456
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I added some minor comments in case you'd want to address them here, but also ok with merging as is and fixing separately or later when we do the actual release - as long as we don't forget it's fine.
@@ -2,6 +2,37 @@ | |||
|
|||
### This is a list detailing changes for all Jetpack releases. | |||
|
|||
## 13.5-a.3 - 2024-05-20 | |||
### Enhancements | |||
- AI Assistant: Enable inline Heading extension. [#37386] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the capitalized 'Heading' intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's referring to the Heading block.
## 13.5-a.3 - 2024-05-20 | ||
### Enhancements | ||
- AI Assistant: Enable inline Heading extension. [#37386] | ||
- Subscribe block: Adds button-only style. [#37341] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Adds' -> 'Add' for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Enhancements | ||
- AI Assistant: Enable inline Heading extension. [#37386] | ||
- Subscribe block: Adds button-only style. [#37341] | ||
- Subscribe block: Allow inside navigation block. [#37439] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... shouldn't it be 'navigation inside the block' instead of 'inside navigation block' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, yeah, I think it makes more sense now. Could eventually maybe write it out to something like "Allow to be placed inside the Navigation block" or something. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my first iteration was "Allow insertion in Navigation block." but that sounded too technical. Your version is pretty good; we can use that in the next release.
- Block Editor: Remove External Link icon styling fix now that the change has been made in WordPress itself. [#37394] | ||
|
||
### Bug fixes | ||
- Slideshow: Fix className issue on frontend - ensures autoplay works properly. [#37378] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we could also fix it later when we do the actual release but just quickly flagging it. I think the first part of the sentence is somewhat unnecessary for the purpose of a plugin changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
### Bug fixes | ||
- Slideshow: Fix className issue on frontend - ensures autoplay works properly. [#37378] | ||
- WordAds: Prevent fatal when post content is null. [#37384] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'fatal' -> 'fatal errors'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes:
Backports changes for mu-wpcom-plugin 2.1.27, jetpack 13.5-a.3
Other information:
Jetpack product discussion
N/a
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Proofread changes.